From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Orgad Shaneh <orgads@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] commit: configure submodules
Date: Sun, 23 Sep 2012 22:57:41 -0700 [thread overview]
Message-ID: <7vmx0g0xpm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <505F5151.2080208@web.de> (Jens Lehmann's message of "Sun, 23 Sep 2012 20:13:37 +0200")
Jens Lehmann <Jens.Lehmann@web.de> writes:
>> Jens, what do you think? I see no reason for anybody other than
>> "submodule init" to call gitmodules_config() that reads from the
>> in-tree .gitmodules file.
>
> I think the copying on init is not what we should do here because
> it sets the user's customization to what ever happened to be in
> .gitmodules at the time he initialized the submodule.
Hrm, why does the user have submodule.$name.$whatever customized
before saying "submodule init $whategver" for that copying to be
problematic?
> So I think Orgad's change is sane and should go in.
Matching what cmd_commit() does to what cmd_status() does, i.e. grab
submodule.$name.ignore from somewhere, is not something I questioned.
The patch is a good change to make them consistent.
What I was wondering was if that is a consistently wrong thing to do
to read from .gitmodules not $GIT_DIR/config.
In any case, the log message I suggested in the review needs to be
updated in the reroll to make it clear that this is about reading
from .gitmodules, not "configuration". AFAICS, gitmodule_config()
does not even read from $GIT_DIR/config, right?
next prev parent reply other threads:[~2012-09-24 5:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 7:37 [PATCH] commit: configure submodules Orgad Shaneh
2012-09-23 8:37 ` Junio C Hamano
2012-09-23 18:13 ` Jens Lehmann
2012-09-24 5:57 ` Junio C Hamano [this message]
2012-09-24 16:27 ` Junio C Hamano
2012-09-24 18:15 ` Jens Lehmann
2012-09-24 18:34 ` Junio C Hamano
2012-09-24 18:49 ` Orgad Shaneh
2012-09-24 19:06 ` Junio C Hamano
2012-09-24 19:16 ` Orgad Shaneh
2012-09-24 19:56 ` Jens Lehmann
2012-09-24 19:59 ` Orgad Shaneh
2012-09-24 20:10 ` Jens Lehmann
2012-09-24 20:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmx0g0xpm.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).