From: Junio C Hamano <gitster@pobox.com>
To: Lanny Ripple <lanny@spotinfluence.com>
Cc: Jeff King <peff@peff.net>, Thomas Rast <trast@inf.ethz.ch>,
git@vger.kernel.org
Subject: Re: Bug: rebase when an author uses accents in name on MacOSx
Date: Fri, 01 Jun 2012 10:57:14 -0700 [thread overview]
Message-ID: <7vmx4m3og5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <0A6ABBD7-01D5-4A24-BF0F-78A7F2C46938@spotinfluence.com> (Lanny Ripple's message of "Fri, 1 Jun 2012 12:05:36 -0500")
Lanny Ripple <lanny@spotinfluence.com> writes:
> I still think the best solution is figuring out if the platform sed is sane at build time and using a full path (via config setup if being able to change the sed used is a priority). Short of that something as simple as
>
> (git-am:699+)
>
> if test -z "$GIT_AUTHOR_EMAIL"
> then
> # Can occur when sed in PATH will not handle UTF8 under LC_ALL=C.
> gettextln "Patch does not have a valid e-mail address."
> stop_here $this
> fi
That is a real fix to the issue (can also happen to name, no?) and
is worth checking.
next prev parent reply other threads:[~2012-06-01 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 22:16 Bug: rebase when an author uses accents in name on MacOSx Lanny Ripple
2012-05-30 23:45 ` Junio C Hamano
2012-05-30 23:57 ` Jürgen Kreileder
2012-05-31 1:19 ` Jeff King
2012-05-31 6:33 ` Junio C Hamano
2012-05-31 13:36 ` Lanny Ripple
2012-05-31 14:28 ` Thomas Rast
2012-05-31 14:56 ` Lanny Ripple
2012-05-31 17:34 ` Junio C Hamano
2012-05-31 17:49 ` Lanny Ripple
2012-05-31 18:33 ` Junio C Hamano
2012-05-31 19:21 ` Lanny Ripple
2012-06-01 9:30 ` Jeff King
2012-06-01 13:56 ` Lanny Ripple
2012-06-02 16:09 ` Jeff King
2012-06-02 16:37 ` Lanny Ripple
2012-06-01 16:19 ` Junio C Hamano
2012-06-01 17:05 ` Lanny Ripple
2012-06-01 17:57 ` Junio C Hamano [this message]
2012-06-02 16:23 ` Jeff King
2012-05-31 9:33 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmx4m3og5.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lanny@spotinfluence.com \
--cc=peff@peff.net \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).