git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jack Nagel <jacknagel@gmail.com>
Subject: Re: [PATCH] Add MYMETA.json to perl/.gitignore
Date: Wed, 28 Dec 2011 22:58:57 -0800	[thread overview]
Message-ID: <7vmxabyiby.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vty4kx7ol.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 28 Dec 2011 21:34:18 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Jack Nagel <jacknagel@gmail.com> writes:
>
>> ExtUtils::MakeMaker generates MYMETA.json in addition to MYMETA.yml
>> since version 6.57_07. As it suggests, it is just meta information about
>
> Are we better off ignoring MYMETA.* instead, so that we won't get affected
> when they start dropping new cruft with the same information in yet more
> different formats?

Just to make sure there is no misunderstanding. The above is _not_ a
rhetorical question that implies that I _think_ the patch should instead
change the existing "MYMETA.yml" to "MYMETA.*" without adding a new entry
to ignore "MYMETA.json". It is a pure question, and a valid answer could
be "I checked with Perl people and they promise they won't be adding any
more MYMETA.foo left and right with new MakeMaker releases", in which case
the original patch is absolutely the right thing to do.

I am simply asking because I do not know.

>
>> the build and is cleaned up with 'make clean', so it should be ignored.
>>
>> Signed-off-by: Jack Nagel <jacknagel@gmail.com>
>> ---
>>  perl/.gitignore |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/perl/.gitignore b/perl/.gitignore
>> index 9235e73..d5c6e22 100644
>> --- a/perl/.gitignore
>> +++ b/perl/.gitignore
>> @@ -1,5 +1,6 @@
>>  perl.mak
>>  perl.mak.old
>> +MYMETA.json
>>  MYMETA.yml
>>  blib
>>  blibdirs

  reply	other threads:[~2011-12-29  6:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-29  4:42 [PATCH] Add MYMETA.json to perl/.gitignore Jack Nagel
2011-12-29  5:34 ` Junio C Hamano
2011-12-29  6:58   ` Junio C Hamano [this message]
2011-12-29  9:50     ` Ævar Arnfjörð Bjarmason
2011-12-29 17:40       ` Jack Nagel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmxabyiby.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jacknagel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).