From: Junio C Hamano <gitster@pobox.com>
To: "Lénaïc Huard" <lenaic@lhuard.fr.eu.org>
Cc: Jakub Narebski <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: provide a way to customize html headers
Date: Thu, 20 Oct 2011 17:37:02 -0700 [thread overview]
Message-ID: <7vmxcv89jl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <201110210046.34679.lenaic@lhuard.fr.eu.org> ("Lénaïc Huard"'s message of "Fri, 21 Oct 2011 00:46:34 +0200")
Lénaïc Huard <lenaic@lhuard.fr.eu.org> writes:
> +GITWEB_SITE_HTMLHEADER =
> GITWEB_SITE_HEADER =
> GITWEB_SITE_FOOTER =
Is it just me or does the inconsistency between the existing two variables
and this new one with a very similar name stand out like a sore something?
It might have been better if GITWEB_SITE_(HEADER|FOOTER) were named with
"_FILE" suffix, but as long as we consider/declare insert_file is the norm
and in-place inclusion of mini-string is an oddball, it is sufficient to
call this GITWEB_SITE_HTML_HEAD_STRING to avoid confusion?
Perhaps GITWEB_SITE_HEADER_STRING and GITWEB_SITE_FOOTER_STRING might turn
out to be useful in the future for in-place inclusion of mini-strings, and
when that happens, you two would thank me for this suggestion ;-)
next prev parent reply other threads:[~2011-10-21 0:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 7:28 [PATCH] gitweb: provide a way to customize html headers Lénaïc Huard
2011-10-17 11:56 ` Jakub Narebski
2011-10-20 22:46 ` Lénaïc Huard
2011-10-21 0:37 ` Junio C Hamano [this message]
2011-10-21 7:09 ` Lénaïc Huard
2011-10-21 19:14 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2011-10-16 20:56 Lénaïc Huard
2011-10-16 21:26 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxcv89jl.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=lenaic@lhuard.fr.eu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).