From: Junio C Hamano <gitster@pobox.com>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] grep --no-index: don't use git standard exclusions
Date: Thu, 15 Sep 2011 12:44:08 -0700 [thread overview]
Message-ID: <7vmxe5pp4n.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7b3551dd84a2bfec78c8db1d14dd2d0e6dda35f6.1316110876.git.bert.wesarg@googlemail.com> (Bert Wesarg's message of "Thu, 15 Sep 2011 20:26:03 +0200")
Bert Wesarg <bert.wesarg@googlemail.com> writes:
> On Wed, Jul 20, 2011 at 22:57, Junio C Hamano <gitster@pobox.com> wrote:
>> - Since 3081623 (grep --no-index: allow use of "git grep" outside a git
>> repository, 2010-01-15) and 59332d1 (Resurrect "git grep --no-index",
>> 2010-02-06), "grep --no-index" incorrectly paid attention to the
>> exclude patterns. We shouldn't have, and we'd fix that bug.
>
> Fix this bug.
On a busy list like this, it is brutal to withhold the better clues you
certainly had when you wrote this message that would help people to locate
the original message you are quoting, and instead forcing everybody to go
back 5000 messages in the archive to find it. E.g.
http://article.gmane.org/gmane.comp.version-control.git/177548
http://mid.gmane.org/7vzkk86577.fsf@alter.siamese.dyndns.org
Or perhaps have
References: <7vzkk86577.fsf@alter.siamese.dyndns.org>
in the header.
As to the patch, I think this addresses only one fourth of the issue
identified in that discussion (it is a good starting point, though).
With this change, it would now make sense to teach --[no-]exclude-standard
to "git grep", and "--exclude-standard" is immediately useful when used
with "--no-index". When we add "git grep --untracked-too" (which lets us
search in the working tree), people can add "--no-exclude-standard" to the
command line to say "I want to find the needle even from an ignored file".
Thanks.
next prev parent reply other threads:[~2011-09-15 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 18:26 [PATCH 1/2] grep: do not use --index in the short usage output Bert Wesarg
2011-09-15 18:26 ` [PATCH 2/2] grep --no-index: don't use git standard exclusions Bert Wesarg
2011-09-15 19:44 ` Junio C Hamano [this message]
2011-09-16 18:23 ` Bert Wesarg
2011-09-27 22:21 ` Re* " Junio C Hamano
2011-09-27 22:22 ` [PATCH 2/2] grep: --untracked and --exclude tests Junio C Hamano
2011-09-28 19:19 ` Re* [PATCH 2/2] grep --no-index: don't use git standard exclusions Bert Wesarg
2011-09-28 20:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxe5pp4n.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).