From: Junio C Hamano <gitster@pobox.com>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
git@vger.kernel.org, Jens.Lehmann@web.de, gitster@pobox.com
Subject: Re: [PATCH v3 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails.
Date: Mon, 25 Jul 2011 10:38:50 -0700 [thread overview]
Message-ID: <7vmxg2s1jp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAH3Anrrbj93briHKpxEjpoVTOnSikQYQyxa4R=C7QKt=punyVw@mail.gmail.com> (Jon Seymour's message of "Mon, 25 Jul 2011 18:45:35 +1000")
Jon Seymour <jon.seymour@gmail.com> writes:
> @@ -173,6 +173,7 @@ int cmd_ls_tree(int argc, const char **argv, const
> char *prefix)
> tree = parse_tree_indirect(sha1);
> if (!tree)
> die("not a tree object");
> - return read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
> + ret = read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
>
> + return ret ? 1 : 0;
> }
Surely, or "return !!read_tree_recursive(...);" is fine as well.
prev parent reply other threads:[~2011-07-25 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 14:59 [PATCH v3 0/2] ls-tree: exit with non-zero status on error Jon Seymour
2011-07-24 14:59 ` [PATCH v3 1/2] Add a test to check that git ls-tree sets non-zero exit code " Jon Seymour
2011-07-24 14:59 ` [PATCH v3 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails Jon Seymour
2011-07-25 1:31 ` Nguyen Thai Ngoc Duy
2011-07-25 8:45 ` Jon Seymour
2011-07-25 12:58 ` Nguyen Thai Ngoc Duy
2011-07-25 16:17 ` Andreas Schwab
2011-07-25 16:46 ` Jens Lehmann
2011-07-25 17:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxg2s1jp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=jon.seymour@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).