From: Junio C Hamano <gitster@pobox.com>
To: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Lasse Makholm <lasse.makholm@gmail.com>
Subject: Re: [PATCH 1/2] diff/status: refactor opportunistic index update
Date: Mon, 21 Mar 2011 12:39:35 -0700 [thread overview]
Message-ID: <7vmxkop8js.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTinUqzgpiX_X+kpUuOSxNqRVp+OC1HOreEkF6yhX@mail.gmail.com> (Piotr Krukowiecki's message of "Mon, 21 Mar 2011 19:46:22 +0100")
Piotr Krukowiecki <piotr.krukowiecki@gmail.com> writes:
> On Mon, Mar 21, 2011 at 6:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> +void update_index_if_able(struct index_state *istate, struct lock_file *lockfile)
>> +{
>> + if (istate->cache_changed) &&
>> + !write_index(istate, lockfile->fd))
>
> Mismatched parenthesis? Should be sth like
>
> + if (istate->cache_changed &&
> + !write_index(istate, lockfile->fd))
Yeah, "rebase -i" gotcha. Applying [2/2] should get rid of it anyway.
next prev parent reply other threads:[~2011-03-21 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 12:40 git status reads too many files Lasse Makholm
2011-03-21 16:41 ` Junio C Hamano
2011-03-21 17:16 ` [PATCH 1/2] diff/status: refactor opportunistic index update Junio C Hamano
2011-03-21 18:46 ` Piotr Krukowiecki
2011-03-21 19:39 ` Junio C Hamano [this message]
2011-03-21 17:18 ` [PATCH 2/2] update $GIT_INDEX_FILE when there are racily clean entries Junio C Hamano
2011-03-21 21:23 ` Lasse Makholm
2011-03-22 0:26 ` Eric Raible
2011-03-21 20:39 ` git status reads too many files Lasse Makholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxkop8js.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lasse.makholm@gmail.com \
--cc=piotr.krukowiecki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).