git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] log.decorate: accept 0/1 bool values
Date: Thu, 18 Nov 2010 09:00:13 -0800	[thread overview]
Message-ID: <7vmxp6d0te.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20101117195259.GA13008@sigill.intra.peff.net> (Jeff King's message of "Wed\, 17 Nov 2010 14\:52\:59 -0500")

Jeff King <peff@peff.net> writes:

> I don't think it is worth closing the hole for no reason on other config
> options, but I am certainly fine with breaking it in the case of
> pager.*.

Hmm, I guess that is fine, but will we hear "Why does it behave
differently only for pager.*" down the line, just like the issue your
patch 1/2 addressed, which was "Why does it behave differently only for
log.decorate?"

  reply	other threads:[~2010-11-18 17:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 17:00 [PATCH 1/2] log.decorate: accept 0/1 bool values Jeff King
2010-11-17 17:04 ` [PATCH 2/2] allow command-specific pagers in pager.<cmd> Jeff King
2010-11-17 19:36 ` [PATCH 1/2] log.decorate: accept 0/1 bool values Junio C Hamano
2010-11-17 19:52   ` Jeff King
2010-11-18 17:00     ` Junio C Hamano [this message]
2010-11-18 17:14       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmxp6d0te.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).