From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 1/5] t1011 (sparse checkout): style nitpicks Date: Mon, 02 Aug 2010 10:22:42 -0700 Message-ID: <7vmxt5lyjh.fsf@alter.siamese.dyndns.org> References: <1280556869-707-1-git-send-email-pclouds@gmail.com> <1280556869-707-2-git-send-email-pclouds@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org, Jonathan Niedier To: =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy X-From: git-owner@vger.kernel.org Mon Aug 02 19:23:00 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ofyj6-0000Dt-Gi for gcvg-git-2@lo.gmane.org; Mon, 02 Aug 2010 19:23:00 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102Ab0HBRWz convert rfc822-to-quoted-printable (ORCPT ); Mon, 2 Aug 2010 13:22:55 -0400 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:34873 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921Ab0HBRWy convert rfc822-to-8bit (ORCPT ); Mon, 2 Aug 2010 13:22:54 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 65064CA893; Mon, 2 Aug 2010 13:22:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=to:cc:subject :references:from:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=8efx3/xBiAVm ed7KH+U/P6KA6SE=; b=AlaDDCmd8xPCtx881oaQHWy/B3kmeP6EE0zSnjK5UNaq vo1BY9tW2SfhqBQLfwjUzx6QYPmSaPeh79YxBTIYAbVA6CIdONJhQSgO5bHshcX6 r1BBf6yig293XI3Enk+8P2X5TvOZhFqi+J1mu9BbxfQKDBn4O9t9GUftLyOKer8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=to:cc:subject :references:from:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=Dbq6Qm NvaIMQSUr02uAZQjyjVXhoC5mDm+3/eo343VFhWzU1tZNscTzZqIDxOGzzQzZO6L X2DQtaGmlh1Ijz2pIDOVylxnuxrQ9F9smGrXba8iLklU/pP7Q3aR3dxxUcFV03X+ Hhth4c05663Bsci8U4DP82P52j0jbY/hxjNFk= Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 18D89CA890; Mon, 2 Aug 2010 13:22:48 -0400 (EDT) Received: from pobox.com (unknown [69.181.135.33]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 26277CA88D; Mon, 2 Aug 2010 13:22:43 -0400 (EDT) In-Reply-To: <1280556869-707-2-git-send-email-pclouds@gmail.com> (=?utf-8?B?Ik5ndXnhu4VuIFRow6FpIE5n4buNYw==?= Duy"'s message of "Sat\, 31 Jul 2010 13\:14\:25 +0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-Pobox-Relay-ID: 9227D73A-9E5A-11DF-B14F-9056EE7EF46B-77302942!a-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy writes: > From: Jonathan Nieder > > Tweak the rest of the script to more closely follow the test > style guide. Guarding setup commands with test_expect_success > makes it easy to see the scope in which some particular data is > used; removal of whitespace after >redirection operators is just > for consistency. > > Signed-off-by: Jonathan Nieder > Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy What happened to the 'test -z "$(cmd)" discards exit status from cmd' p= art of Jonathan's patch?