git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Björn Gustavsson" <bgustavsson@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] rebase -i: abort cleanly if the editor fails to launch
Date: Sat, 19 Dec 2009 23:24:10 -0800	[thread overview]
Message-ID: <7vmy1ecdlx.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0912192156030.4985@pacific.mpi-cbg.de> (Johannes Schindelin's message of "Sat\, 19 Dec 2009 21\:57\:16 +0100 \(CET\)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> The non-existent editor also aborts with a non-zero status.

Thanks; that is a good point.  Perhaps we might want to say what editor we
tried to run in the error message.

>> An editor that can exit with non-zero status on demand could use this
>> codepath to abort the rebase,
>
> Removing all lines of the edit script will abort an interactive rebase.

I guess you replied too fast without reading the message to the end ;-)

  reply	other threads:[~2009-12-20  7:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-19 12:04 [PATCH] rebase -i: abort cleanly if the editor fails to launch Björn Gustavsson
2009-12-19 20:44 ` Junio C Hamano
2009-12-19 20:57   ` Johannes Schindelin
2009-12-20  7:24     ` Junio C Hamano [this message]
2009-12-20  7:31   ` Björn Gustavsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmy1ecdlx.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bgustavsson@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).