From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
pi song <pi.songs@gmail.com>,
git@vger.kernel.org, gitster@pobox.com,
rene.scharfe@lsrfire.ath.cx
Subject: Re: [PATCH2/2] Libify blame
Date: Mon, 16 Mar 2009 17:48:18 -0700 [thread overview]
Message-ID: <7vmyblt1nx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090316200418.GM3817@genesis.frugalware.org> (Miklos Vajna's message of "Mon, 16 Mar 2009 21:04:18 +0100")
Miklos Vajna <vmiklos@frugalware.org> writes:
> On Mon, Mar 16, 2009 at 02:49:31PM +0100, Sverre Rabbelier <srabbelier@gmail.com> wrote:
>> It would be nice if you could paste the output of "git diff -M" after
>> the triple-dash to show that it is indeed only a small change.
>
> Or just use git format-patch -M?
No file disappears, so -M alone won't cut it.
I think -B -M may do something interesting, but even then, I suspect you
will see a lot of deletions (e.g. you start from two copies of the
original builtin-blame.c and remove different parts to arrive at the new
builtin-blame.c and blame.c) that amounts roughly about the same size as
the original builtin-blame.c itself.
prev parent reply other threads:[~2009-03-17 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 13:30 [PATCH2/2] Libify blame pi song
2009-03-16 13:49 ` Sverre Rabbelier
2009-03-16 20:04 ` Miklos Vajna
2009-03-16 23:11 ` pi song
2009-03-17 0:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyblt1nx.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pi.songs@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=srabbelier@gmail.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).