From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH2/2] Libify blame Date: Mon, 16 Mar 2009 17:48:18 -0700 Message-ID: <7vmyblt1nx.fsf@gitster.siamese.dyndns.org> References: <49BE5466.5050202@gmail.com> <20090316200418.GM3817@genesis.frugalware.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sverre Rabbelier , pi song , git@vger.kernel.org, gitster@pobox.com, rene.scharfe@lsrfire.ath.cx To: Miklos Vajna X-From: git-owner@vger.kernel.org Tue Mar 17 01:50:46 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LjNW2-0005Ys-0g for gcvg-git-2@gmane.org; Tue, 17 Mar 2009 01:50:46 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbZCQAs3 (ORCPT ); Mon, 16 Mar 2009 20:48:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752977AbZCQAs3 (ORCPT ); Mon, 16 Mar 2009 20:48:29 -0400 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:46858 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715AbZCQAs2 (ORCPT ); Mon, 16 Mar 2009 20:48:28 -0400 Received: from localhost.localdomain (unknown [127.0.0.1]) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id E719A6068; Mon, 16 Mar 2009 20:48:26 -0400 (EDT) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTPSA id F15046063; Mon, 16 Mar 2009 20:48:19 -0400 (EDT) In-Reply-To: <20090316200418.GM3817@genesis.frugalware.org> (Miklos Vajna's message of "Mon, 16 Mar 2009 21:04:18 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 5390914C-128D-11DE-A03C-C5D912508E2D-77302942!a-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Miklos Vajna writes: > On Mon, Mar 16, 2009 at 02:49:31PM +0100, Sverre Rabbelier wrote: >> It would be nice if you could paste the output of "git diff -M" after >> the triple-dash to show that it is indeed only a small change. > > Or just use git format-patch -M? No file disappears, so -M alone won't cut it. I think -B -M may do something interesting, but even then, I suspect you will see a lot of deletions (e.g. you start from two copies of the original builtin-blame.c and remove different parts to arrive at the new builtin-blame.c and blame.c) that amounts roughly about the same size as the original builtin-blame.c itself.