From: Junio C Hamano <gitster@pobox.com>
To: Finn Arne Gangstad <finnag@pvv.org>
Cc: git@vger.kernel.org, John Tapsell <johnflux@gmail.com>,
Andreas Ericsson <ae@op5.se>
Subject: Re: [RFC PATCH] git push: Push nothing if no refspecs are given or configured
Date: Thu, 05 Mar 2009 14:43:49 -0800 [thread overview]
Message-ID: <7vmybzy4ii.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090305221529.GA25871@pvv.org> (Finn Arne Gangstad's message of "Thu, 5 Mar 2009 23:15:29 +0100")
If you want to pursue this, you at least need three patches, preferably
four:
(1) Add a configuration option the existing users can use to ask for
"with nothing else, please continue to default to matching refs".
Add a logic to tell "nothing is configured, hence we default to
matching refs" and "the user explicitly told us either via the
command line, or in the configuration file to use matching refs"
cases. Use the logic to issue a *warning* upon the former case that
tells the users the following, very loudly:
- "default to push matching" may be changed in a future version of
git to "default to push nothing";
- The user can squelch the warning by various ways:
- If you want to keep the "matching refs" behaviour, do $this...
- If you want to have $this behaviour, do $that...
- ...
Keep the default for the unconfigured case, after issuing the
warning, to the matching refs.
(2) Add a deprecation notice to Documentation/RelNotes-1.6.3.txt similar
to the way denyCurrentBranch was announced in 1.6.2 release notes (I
need to carry that part forward to the draft release notes to 1.6.3).
Mention that these two patches are proposed to be applied immediately.
(3) Flip the default for unconfigured case to "nothing". Update the
warning message you wrote in (1) to explain that:
- The default used to be "matching refs", but it now is "nothing".
This message is given loudly because a silent change of default
is dangerous to users.
- The user can squelch the warning by doing ... (I expect the
instructions will stay the same as in (1)).
Mention that this patch is proposed to be applied in the next major
update (perhaps 1.7.0).
(4) Remove the warning but keep the default to "nothing". Mention that
this is to be applied long after (3).
I won't comment on code quality other than hinting that you do not want to
reinvent has_multiple_bits().
next prev parent reply other threads:[~2009-03-05 22:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 22:15 [RFC PATCH] git push: Push nothing if no refspecs are given or configured Finn Arne Gangstad
2009-03-05 22:18 ` Sverre Rabbelier
2009-03-05 22:22 ` Markus Heidelberg
2009-03-05 22:25 ` Markus Heidelberg
2009-03-05 22:26 ` Sverre Rabbelier
2009-03-06 10:24 ` Johannes Schindelin
2009-03-06 10:32 ` Junio C Hamano
2009-03-06 11:17 ` Sverre Rabbelier
2009-03-06 11:48 ` Finn Arne Gangstad
2009-03-06 12:07 ` Johannes Schindelin
2009-03-06 13:58 ` Finn Arne Gangstad
2009-03-06 15:25 ` Jakub Narebski
2009-03-06 17:17 ` Junio C Hamano
2009-03-07 2:06 ` Johannes Schindelin
2009-03-06 23:00 ` Johannes Schindelin
2009-03-06 12:26 ` John Tapsell
2009-03-06 15:27 ` Jakub Narebski
2009-03-05 22:43 ` Junio C Hamano [this message]
2009-03-06 10:37 ` Johannes Schindelin
2009-03-09 20:39 ` Markus Heidelberg
2009-03-09 20:48 ` Johannes Schindelin
2009-03-09 21:10 ` Markus Heidelberg
2009-03-09 21:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmybzy4ii.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=ae@op5.se \
--cc=finnag@pvv.org \
--cc=git@vger.kernel.org \
--cc=johnflux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).