From: Junio C Hamano <gitster@pobox.com>
To: Mike Ralphson <mike.ralphson@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org, Todd Zullinger <tmz@pobox.com>,
Rafael Darder Calvo <rdarder@spiralti.com>,
mike@abacus.co.uk
Subject: Re: [PATCH v2] Make sure objects/pack exists before creating a new pack
Date: Thu, 26 Feb 2009 09:07:33 -0800 [thread overview]
Message-ID: <7vmyc9t9d6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: e2b179460902260754t38618c3fsf22a699ec35070cf@mail.gmail.com
Mike Ralphson <mike.ralphson@gmail.com> writes:
> 2009/2/26 Johannes Sixt <j.sixt@viscovery.net>:
>> Mike Ralphson schrieb:
>>> Even with j6t's patch, I'm seeing failures in t5300--pack-object.sh on AIX 5.3
>>>
>>> * FAIL 15: survive missing objects/pack directory
>>> fatal: Unable to create temporary file (): No such file or directory
>>
>> I can confirm this. Your patch is good. I wrapped it up:
>>
>> -- snip --
>> From: Mike Ralphson <mike.ralphson@gmail.com>
>> Subject: [PATCH] Fix odb_mkstemp() on AIX
>>
>> The AIX mkstemp() modifies its template parameter to an empty string if
>> the call fails. The existing code had already recomputed the template,
>> but too late to be good.
>>
>> See also 6ff6af62, which fixed this problem in a different spot.
>
> Ah, I should have remembered that one.
>
> If my $DAYJOB email address could be used in the From, as per this s-o-b:
>
> Signed-off-by: Mike Ralphson <mike@abacus.co.uk>
Thanks.
prev parent reply other threads:[~2009-02-26 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 17:04 git-push error: Cannot write keep file Rafael Darder Calvo
2009-02-24 17:31 ` Junio C Hamano
2009-02-24 21:21 ` Rafael Darder Calvo
2009-02-25 7:11 ` [PATCH v2] Make sure objects/pack exists before creating a new pack Junio C Hamano
2009-02-25 7:15 ` Junio C Hamano
2009-02-26 9:19 ` Johannes Sixt
2009-02-26 11:19 ` Mike Ralphson
2009-02-26 15:31 ` Johannes Sixt
2009-02-26 15:54 ` Mike Ralphson
2009-02-26 17:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyc9t9d6.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=mike.ralphson@gmail.com \
--cc=mike@abacus.co.uk \
--cc=rdarder@spiralti.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).