From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, "Adeodato Simó" <dato@net.com.org.es>
Subject: Re: [PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing
Date: Mon, 29 Dec 2008 01:46:02 -0800 [thread overview]
Message-ID: <7vmyefco11.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1230542658-9758-1-git-send-email-dato@net.com.org.es> (Adeodato Simó's message of "Mon, 29 Dec 2008 10:24:18 +0100")
Adeodato Simó <dato@net.com.org.es> writes:
> I was reading this test case, and it took a small bit to figure out the
> editor was not being used at all. I hope there was no hidden reason for
> it to be there, and it can go away.
That 'zort' came from 1320857 (builtin-commit: fix --signoff, 2007-11-11),
and I _think_ it is trying to make sure that presense of "-F -" makes the
editor not to trigger.
Dscho?
next prev parent reply other threads:[~2008-12-29 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 9:24 [PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing Adeodato Simó
2008-12-29 9:46 ` Junio C Hamano [this message]
2008-12-29 9:52 ` Adeodato Simó
2008-12-29 9:57 ` Junio C Hamano
2008-12-30 12:04 ` Johannes Schindelin
2009-01-09 17:30 ` [PATCH v2] t7501-commit.sh: explicitly check that -F prevents invoking the editor Adeodato Simó
2009-01-10 10:19 ` Johannes Schindelin
2009-01-10 10:32 ` Adeodato Simó
2009-01-10 11:48 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyefco11.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dato@net.com.org.es \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).