From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: demerphq <demerphq@gmail.com>,
rene.scharfe@lsrfire.ath.cx, git@vger.kernel.org
Subject: Re: [PATCH] describe: Avoid unnecessary warning when using --all
Date: Fri, 26 Dec 2008 16:18:21 -0800 [thread overview]
Message-ID: <7vmyeijws2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081226220201.GA20516@spearce.org> (Shawn O. Pearce's message of "Fri, 26 Dec 2008 14:02:01 -0800")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> In 212945d4 ("Teach git-describe to verify annotated tag names
> before output") git-describe learned how to output a warning if
> an annotated tag object was matched but its internal name doesn't
> match the local ref name.
>
> However, "git describe --all" causes the local ref name to be
> prefixed with "tags/", so we need to skip over this prefix before
> comparing the local ref name with the name recorded inside of the
> tag object.
>
> Patch-by: René Scharfe <rene.scharfe@lsrfire.ath.cx>
> Signed-off-by: Shawn O. Pearce <sop@google.com>
> ---
> IMHO, suitable for maint...
Yeah, do you prefer to be known as "sop" over "spearce" these days, by the
way? It does not make a difference to me but I just noticed that Author
and S-o-b won't be matching, so I am just being curious.
next prev parent reply other threads:[~2008-12-27 0:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 22:02 [PATCH] describe: Avoid unnecessary warning when using --all Shawn O. Pearce
2008-12-27 0:18 ` Junio C Hamano [this message]
2008-12-27 0:26 ` Shawn O. Pearce
2008-12-27 0:38 ` Miklos Vajna
2008-12-27 0:40 ` Miklos Vajna
2008-12-27 0:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyeijws2.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).