From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Matt McCutchen <matt@mattmccutchen.net>,
git@vger.kernel.org,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: Re: [PATCH try 2] gitweb: Add option to put a trailing slash on pathinfo-style project URLs
Date: Sat, 13 Dec 2008 14:37:13 -0800 [thread overview]
Message-ID: <7vmyez4s86.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <m3tz97g329.fsf@localhost.localdomain> (Jakub Narebski's message of "Sat, 13 Dec 2008 13:47:46 -0800 (PST)")
Jakub Narebski <jnareb@gmail.com> writes:
>> + # If you want a trailing slash on the project path (because, for
>> + # example, you have a real directory at that URL and are using
>> + # some rewrite magic to invoke gitweb), then set:
>> + # $feature{'pathinfo'}{'default'} = [1, 1];
>> +
>
> Are any disadvantages to having it always enabled?
Good question.
>> + my @use_pathinfo = gitweb_get_feature('pathinfo');
>
> Why not name those variables for better readability?
>
> + my ($use_pathinfo, $trailing_slash) = gitweb_get_feature('pathinfo');
Good suggestion.
next prev parent reply other threads:[~2008-12-13 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 19:10 [PATCH] gitweb: Add option to put a trailing slash on pathinfo-style project URLs Matt McCutchen
2008-12-13 21:11 ` [PATCH try 2] " Matt McCutchen
2008-12-13 21:47 ` Jakub Narebski
2008-12-13 22:23 ` Giuseppe Bilotta
2008-12-14 1:13 ` Matt McCutchen
2008-12-14 23:39 ` Jakub Narebski
2008-12-14 23:55 ` Jakub Narebski
2008-12-13 22:37 ` Junio C Hamano [this message]
2008-12-14 1:43 ` Matt McCutchen
2008-12-14 23:20 ` Jakub Narebski
2008-12-14 23:58 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyez4s86.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=jnareb@gmail.com \
--cc=matt@mattmccutchen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).