From: Junio C Hamano <gitster@pobox.com>
To: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
Cc: "Scott Chacon" <schacon@gmail.com>, git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] Add a built-in alias for 'stage' to the 'add' command
Date: Tue, 02 Dec 2008 18:18:25 -0800 [thread overview]
Message-ID: <7vmyfehuha.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: fcaeb9bf0812020436n69a21c96g4c13976e493372d9@mail.gmail.com
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:
> On 12/2/08, Scott Chacon <schacon@gmail.com> wrote:
>> diff --git a/git.c b/git.c
>> index 89feb0b..9e5813c 100644
>> --- a/git.c
>> +++ b/git.c
>> @@ -266,6 +266,7 @@ static void handle_internal_command(int argc, const char **argv)
>> const char *cmd = argv[0];
>> static struct cmd_struct commands[] = {
>> { "add", cmd_add, RUN_SETUP | NEED_WORK_TREE },
>> + { "stage", cmd_add, RUN_SETUP | NEED_WORK_TREE },
>> { "annotate", cmd_annotate, RUN_SETUP },
>> { "apply", cmd_apply },
>> { "archive", cmd_archive },
>
> Nit-picking. There are some references to "git add" in builtin-add.c,
> like help usage or error message ("Maybe you wanted to say 'git add
> .'?\n"). Should it refer to "git stage" instead as well?
I do not think that is necessary. As git-stage(1) makes it clear, it is
an alias to "add", not the other way around.
next prev parent reply other threads:[~2008-12-03 2:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 6:14 [PATCH] Add a built-in alias for 'stage' to the 'add' command Scott Chacon
2008-12-02 12:36 ` Nguyen Thai Ngoc Duy
2008-12-03 2:18 ` Junio C Hamano [this message]
2008-12-03 2:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyfehuha.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=schacon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).