Re: [PATCH 5/6] archive: allow --exec and --remote without equal sign

[Junio C Hamano <gitster@pobox.com>]

Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Convert git archive to parse_options().  The parameters --remote and --exec
> are still handled by their special parser.  Define them anyway in order for
> them to show up in the usage notice.
>
> Note: in a command like "git archive --prefix --remote=a/ HEAD", the string
> "--remote=a/" will be interpreted as a remote option, not a prefix, because
> that special parser sees it first.  If one needs such a strange prefix, it
> needs to be specified like this: "git archive --prefix=--remote=a/ HEAD"
> (with an equal sign).
>
> Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
> ---
>  archive.c |  110 +++++++++++++++++++++++++++++++++++++-----------------------
>  1 files changed, 68 insertions(+), 42 deletions(-)

Hmph, somewhat dubious.

The real point of parse-options was to make the code smaller, easier to
maintain and command line handling more consistent.  At least this patch
seems to fail on the two out of three counts.

All of the other patches made obvious sense to me and are queued for -rc1
but I'd like to backburner this one.