From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [TOY PATCH] git wrapper: show similar command names for an unknown command
Date: Sat, 07 Jun 2008 11:08:00 -0700 [thread overview]
Message-ID: <7vmylxnmnz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080607175103.GA5822@steel.home> (Alex Riesen's message of "Sat, 7 Jun 2008 19:51:03 +0200")
Alex Riesen <raa.lkml@gmail.com> writes:
> Johannes Schindelin, Sat, Jun 07, 2008 17:04:14 +0200:
>> - for (i = 0; i < main_cmds.cnt; i++) {
>> + for (i = 0; i < main_cmds.cnt && i < 5; i++) {
>
> I accidentally considered "i" just the index in the global command
> table. Of course it is better :)
That confusion however shows how hacky the approach to clobber the
main_cmds global table by stuffing other things in it and sorting, without
saying "who cares, we will exit after we are done with this processing
anyway". If this patch were for inclusion, such a comment should be there
immediately before it starts to muck with the command table.
next prev parent reply other threads:[~2008-06-07 18:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 6:48 [TOY PATCH] git wrapper: show similar command names for an unknown command Johannes Schindelin
2008-06-05 8:19 ` [PATCH] Add subcommand "help" to the list of most commonly used subcommands Teemu Likonen
2008-06-05 10:32 ` Johannes Schindelin
2008-06-05 10:52 ` Teemu Likonen
2008-06-05 10:57 ` [PATCH v2 1/2] " Teemu Likonen
2008-06-05 10:57 ` [PATCH v2 2/2] More informative short description for git-help.txt Teemu Likonen
2008-06-05 12:58 ` [PATCH] Add subcommand "help" to the list of most commonly used subcommands Johannes Schindelin
2008-06-05 11:21 ` Sverre Rabbelier
2008-06-05 13:22 ` Teemu Likonen
2008-06-05 18:13 ` Junio C Hamano
2008-06-05 18:38 ` Pieter de Bie
2008-06-05 21:15 ` Teemu Likonen
2008-06-05 21:17 ` Junio C Hamano
2008-06-06 5:11 ` David Symonds
2008-06-05 18:42 ` Wincent Colaiuta
2008-06-05 19:15 ` Sverre Rabbelier
2008-06-05 20:59 ` [TOY PATCH] git wrapper: show similar command names for an unknown command Dirk Süsserott
2008-06-05 23:00 ` Johannes Schindelin
2008-06-06 12:15 ` Robin Rosenberg
2008-06-06 14:18 ` Wincent Colaiuta
2008-06-07 7:27 ` Alex Riesen
2008-06-07 15:04 ` Johannes Schindelin
2008-06-07 17:51 ` Alex Riesen
2008-06-07 18:08 ` Junio C Hamano [this message]
2008-06-08 15:07 ` Johannes Schindelin
2008-06-08 15:14 ` Dirk Süsserott
2008-06-08 17:53 ` Junio C Hamano
2008-06-08 23:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmylxnmnz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).