From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pack-objects: proper pack time stamping with --max-pack-size
Date: Thu, 13 Mar 2008 21:33:20 -0700 [thread overview]
Message-ID: <7vmyp1vsa7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0803131440590.2947@xanadu.home> (Nicolas Pitre's message of "Thu, 13 Mar 2008 14:59:29 -0400 (EDT)")
Nicolas Pitre <nico@cam.org> writes:
> Runtime pack access is done in the pack file mtime order since recent
> packs are more likely to contain frequently used objects than old packs.
> However the --max-pack-size option can produce multiple packs with mtime
> in the reversed order as newer objects are always written first.
>
> Let's modify mtime of later pack files (when any) so they appear older
> than preceding ones when a repack creates multiple packs.
>
> Signed-off-by: Nicolas Pitre <nico@cam.org>
> ---
> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
> index f504cff..4c2ed70 100644
> --- a/builtin-pack-objects.c
> +++ b/builtin-pack-objects.c
> @@ -17,6 +17,8 @@
> #include "progress.h"
> #include "refs.h"
>
> +#include <utime.h>
> +
Hmmm. Shouldn't this go to git-compat-util.h?
next prev parent reply other threads:[~2008-03-14 4:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 18:59 [PATCH] pack-objects: proper pack time stamping with --max-pack-size Nicolas Pitre
2008-03-13 20:59 ` Junio C Hamano
2008-03-14 4:33 ` Junio C Hamano [this message]
2008-03-14 4:39 ` Nicolas Pitre
2008-03-14 5:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyp1vsa7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).