From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Andy Whitcroft <apw@shadowen.org>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] shortlog: take the first populated line of the description
Date: Wed, 05 Mar 2008 14:14:10 -0800 [thread overview]
Message-ID: <7vmypclsy5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0803051638150.2947@xanadu.home> (Nicolas Pitre's message of "Wed, 05 Mar 2008 16:47:29 -0500 (EST)")
Nicolas Pitre <nico@cam.org> writes:
> On Wed, 5 Mar 2008, Junio C Hamano wrote:
>
>> I think Andy's fix to make the output side take away
>> unnecessary blank lines is unconditionally good.
>
> It is not "bad" in itself. However that feels like papering over
> another problem which IMHO has greater merits to be fixed. We have
> given special semantics to the first line of a commit log in many other
> places now, so unless all those places are also made aware of
> substandard commit logs too, I think it would be more productive to make
> sure those logs are semi sensible upon entering Git in the first place
> instead.
My understanding of the current status when I wrote that message
was that everybody at commit.c layer (that is, everybody except
shortlog) strips such garbage. Do you have a specific broken
one in mind?
I suspect --pretty=format:%s might be broken; I didn't check.
prev parent reply other threads:[~2008-03-05 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 14:24 [PATCH] shortlog: take the first populated line of the description Andy Whitcroft
2008-03-05 14:48 ` Johannes Schindelin
2008-03-05 16:43 ` Andy Whitcroft
2008-03-05 16:51 ` Johannes Schindelin
2008-03-05 18:47 ` Nicolas Pitre
2008-03-05 21:27 ` Junio C Hamano
2008-03-05 21:47 ` Nicolas Pitre
2008-03-05 22:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmypclsy5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=apw@shadowen.org \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).