From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix amending of a commit with an empty message
Date: Thu, 21 Feb 2008 12:56:52 -0800 [thread overview]
Message-ID: <7vmyput4dn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080221203802.GB20143@steel.home> (Alex Riesen's message of "Thu, 21 Feb 2008 21:38:02 +0100")
Alex Riesen <raa.lkml@gmail.com> writes:
> In this one. I am a bit unsure regarding the change (it looks a little
> too strong), even though it passes the test suite.
I think that is because your new test is faulty.
Instead of ':' I complained about, try having "echo foo" there.
I think it will still fail.
So your test failure is not about "a commit with an empty message"
at all.
Look at the previous test and how we allow an empty commit (not
"with empty message", but "with the same tree as its sole
parent") to be made and amended.
Having said that, here is a quiz. When the user says "git
commit --amend", what are the valid reasons not to allow it,
other than:
- the index is unmerged.
- the branch is yet to be born.
next prev parent reply other threads:[~2008-02-21 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 19:54 [PATCH] A test for commit --amend allowing changing of a very empty commit message Alex Riesen
2008-02-21 20:23 ` Junio C Hamano
2008-02-21 20:35 ` Alex Riesen
2008-02-21 20:38 ` [PATCH] Fix amending of a commit with an empty message Alex Riesen
2008-02-21 20:56 ` Junio C Hamano [this message]
2008-02-21 21:32 ` Alex Riesen
2008-02-21 22:01 ` Junio C Hamano
2008-02-21 20:57 ` [PATCH] A test for commit --amend allowing changing of a very empty commit message Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyput4dn.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).