From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: squelch warning due to comparing undefined $_ to ""
Date: Wed, 20 Feb 2008 10:37:29 -0800 [thread overview]
Message-ID: <7vmypv5v9y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1203486907-12304-1-git-send-email-jaysoffian@gmail.com
Jay Soffian <jaysoffian@gmail.com> writes:
> The check to see if initial_reply_to is defined was also comparing $_ to
> "" for a reason I cannot ascertain (looking at the commit which made the
> change didn't provide enlightenment), but if $_ is undefined, perl
> generates a warning.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> ---
> Junio, the commit which introduced the change was yours, but I don't
> see why you were comparing $_ to "".
I think it was meant to check for $initial_reply_to being empty
(i.e. not compare $_ but the variable), but even if that is the
case I do not think the check would make a difference.
So the patch looks good. Thanks.
prev parent reply other threads:[~2008-02-20 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 5:55 [PATCH] send-email: squelch warning due to comparing undefined $_ to "" Jay Soffian
2008-02-20 18:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmypv5v9y.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).