From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Miklos Vajna <vmiklos@frugalware.org>
Subject: [PATCH] git-clean: make "Would remove ..." path relative to cwd again
Date: Thu, 03 Jan 2008 20:47:50 -0800 [thread overview]
Message-ID: <7vmyrmmc21.fsf@gitster.siamese.dyndns.org> (raw)
The rewrite changed the output to use the path relative to the
top of the work tree without a good reason. This fixes it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin-clean.c | 21 +++++++++++++++------
1 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/builtin-clean.c b/builtin-clean.c
index ae30d4e..6cad8ea 100644
--- a/builtin-clean.c
+++ b/builtin-clean.c
@@ -34,6 +34,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
struct dir_struct dir;
const char *path, *base;
static const char **pathspec;
+ int prefix_offset = 0;
char *seen = NULL;
struct option options[] = {
OPT__QUIET(&quiet),
@@ -71,6 +72,8 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
if (!ignored)
setup_standard_excludes(&dir);
+ if (prefix)
+ prefix_offset = strlen(prefix);
pathspec = get_pathspec(prefix, argv);
read_cache();
@@ -132,26 +135,32 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
if (S_ISDIR(st.st_mode)) {
strbuf_addstr(&directory, ent->name);
if (show_only && (remove_directories || matches)) {
- printf("Would remove %s\n", directory.buf);
+ printf("Would remove %s\n",
+ directory.buf + prefix_offset);
} else if (quiet && (remove_directories || matches)) {
remove_dir_recursively(&directory, 0);
} else if (remove_directories || matches) {
- printf("Removing %s\n", directory.buf);
+ printf("Removing %s\n",
+ directory.buf + prefix_offset);
remove_dir_recursively(&directory, 0);
} else if (show_only) {
- printf("Would not remove %s\n", directory.buf);
+ printf("Would not remove %s\n",
+ directory.buf + prefix_offset);
} else {
- printf("Not removing %s\n", directory.buf);
+ printf("Not removing %s\n",
+ directory.buf + prefix_offset);
}
strbuf_reset(&directory);
} else {
if (pathspec && !matches)
continue;
if (show_only) {
- printf("Would remove %s\n", ent->name);
+ printf("Would remove %s\n",
+ ent->name + prefix_offset);
continue;
} else if (!quiet) {
- printf("Removing %s\n", ent->name);
+ printf("Removing %s\n",
+ ent->name + prefix_offset);
}
unlink(ent->name);
}
--
1.5.4.rc2.17.g257f
next reply other threads:[~2008-01-04 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 4:47 Junio C Hamano [this message]
2008-01-04 15:41 ` [PATCH] git-clean: make "Would remove ..." path relative to cwd again Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyrmmc21.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox