From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Kristian Høgsberg" <krh@redhat.com>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix config lockfile handling.
Date: Fri, 14 Dec 2007 12:07:33 -0800 [thread overview]
Message-ID: <7vmysdqbui.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712141928240.27959@racer.site> (Johannes Schindelin's message of "Fri, 14 Dec 2007 19:29:03 +0000 (GMT)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi,
>
> On Fri, 14 Dec 2007, Kristian Høgsberg wrote:
>
>> - struct lock_file *lock = NULL;
>> + struct lock_file lock;
>
> AFAICT this cannot work. At least not reliably. An atexit() handler will
> access all (even closed) lockfiles.
Correct. It cannot be on the stack.
next prev parent reply other threads:[~2007-12-14 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 19:22 config.c fixes Kristian Høgsberg
2007-12-14 19:22 ` [PATCH 1/2] Fix config lockfile handling Kristian Høgsberg
2007-12-14 19:22 ` [PATCH 2/2] Use a strbuf for building up section header and key/value pair strings Kristian Høgsberg
2007-12-14 19:29 ` [PATCH 1/2] Fix config lockfile handling Johannes Schindelin
2007-12-14 20:07 ` Junio C Hamano [this message]
2007-12-14 20:15 ` Johannes Schindelin
2007-12-14 21:18 ` Junio C Hamano
2007-12-14 19:32 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmysdqbui.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).