From: Junio C Hamano <gitster@pobox.com>
To: Wincent Colaiuta <win@wincent.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] "diff --check" should affect exit status
Date: Wed, 12 Dec 2007 01:16:20 -0800 [thread overview]
Message-ID: <7vmysg8e8r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1197447122-93416-3-git-send-email-win@wincent.com> (Wincent Colaiuta's message of "Wed, 12 Dec 2007 09:12:02 +0100")
Wincent Colaiuta <win@wincent.com> writes:
> "git diff" has a --check option that can be used to check for whitespace
> problems but it only reported by printing warnings to the
> console.
The primary use of this option used to be to see where the breakages are
in order to fix them up (IOW, the option was not about seeing if
breakage exists or not), but that is much easier with --color output
these days.
It is probably a good idea to do this, although I do not care much about
it either way. It probably could replace the sample pre-commit hook
currently implemented in Perl. As I happen to be fairly familiar with
the area, I'll take a look at the patch if/when I find time.
Thanks.
next prev parent reply other threads:[~2007-12-12 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 8:12 [RFC PATCH 0/2] diff whitespace tweaks Wincent Colaiuta
2007-12-12 8:12 ` [PATCH 1/2] Use "whitespace" consistently Wincent Colaiuta
2007-12-12 8:12 ` [PATCH 2/2] "diff --check" should affect exit status Wincent Colaiuta
2007-12-12 9:16 ` Junio C Hamano [this message]
2007-12-12 9:56 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmysg8e8r.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).