From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC] use typechange as rename source
Date: Thu, 29 Nov 2007 17:10:45 -0800 [thread overview]
Message-ID: <7vmyswsfl6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071129141452.GA32670@coredump.intra.peff.net> (Jeff King's message of "Thu, 29 Nov 2007 09:14:53 -0500")
Jeff King <peff@peff.net> writes:
> OK. What next? Did the patch I sent make sense? Do you want a cleaned up
> version with a commit message and signoff, or does it need work?
It just hit me that breaking (as in diffcore-break) a filepair that is a
typechange may yield the same result, and if it works, that would be
conceptually cleaner. After all, a typechange is the ultimate form of
total rewriting (the similarity between the preimage and the postimage
is very low -- even their types are different, let alone contents).
Compared to that, the rename_used++ in that codepath you touched feels
more magic to me.
next prev parent reply other threads:[~2007-11-30 1:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 17:12 [RFC] use typechange as rename source Jeff King
2007-11-29 0:02 ` Junio C Hamano
2007-11-29 14:14 ` Jeff King
2007-11-30 1:10 ` Junio C Hamano [this message]
2007-11-30 1:57 ` Jeff King
2007-12-01 2:36 ` Junio C Hamano
2007-12-01 4:34 ` Jeff King
2007-12-01 6:08 ` Junio C Hamano
2007-12-01 6:13 ` Junio C Hamano
2007-12-01 6:35 ` Junio C Hamano
2007-12-01 6:49 ` Jeff King
2007-12-02 19:15 ` Junio C Hamano
2007-12-03 1:20 ` Jeff King
2007-12-01 6:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmyswsfl6.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).