From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 01/11] Fix memory leak in traverse_commit_list
Date: Fri, 09 Nov 2007 14:43:33 -0800 [thread overview]
Message-ID: <7vmytnqbu2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071109110610.GA19368@spearce.org> (Shawn O. Pearce's message of "Fri, 9 Nov 2007 06:06:10 -0500")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> diff --git a/list-objects.c b/list-objects.c
> index e5c88c2..713bef9 100644
> --- a/list-objects.c
> +++ b/list-objects.c
> @@ -170,4 +170,11 @@ void traverse_commit_list(struct rev_info *revs,
> }
> for (i = 0; i < objects.nr; i++)
> show_object(&objects.objects[i]);
> + free(objects.objects);
> + if (revs->pending.nr) {
> + revs->pending.nr = 0;
> + revs->pending.alloc = 0;
> + revs->pending.objects = NULL;
> + free(revs->pending.objects);
> + }
> }
It is locally verifiable that objects.objects are no longer
needed after this point, but it made me a bit nervous about
freeing of revs->pending.objects.
I think the existing callers are all Ok, but somebody else
should double check.
next prev parent reply other threads:[~2007-11-09 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 11:06 [PATCH 01/11] Fix memory leak in traverse_commit_list Shawn O. Pearce
2007-11-09 22:43 ` Junio C Hamano [this message]
2007-11-09 23:51 ` Johannes Schindelin
2007-11-11 5:17 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmytnqbu2.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).