git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Miles Bader <miles@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make git-archimport log entries more consistent
Date: Wed, 29 Aug 2007 20:14:17 -0700	[thread overview]
Message-ID: <7vmyw9af3q.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <617indss2f.fsf@fencepost.gnu.org> (Miles Bader's message of "Wed, 29 Aug 2007 21:56:56 -0400")

Miles Bader <miles@gnu.org> writes:

> When appending the "git-archimport-id:" line to the end of log entries,
> git-archimport would use two blank lines as a separator when there was no
> body in the arch log (only a Summary: line), and zero blank lines when there
> was a body (making it hard to see the break between the actual log message
> and the git-archimport-id: line).
>
> This patch makes git-archimport generate one blank line as a separator in all
> cases.

I would not have any problem with what the result of this patch
would record in the commits, if it was what it did from the very
beginning.  But this is a change in behaviour; I'd like to know
if people who use archimport _rely_ on the current behaviour...

Anybody?

  reply	other threads:[~2007-08-30  3:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-30  1:56 [PATCH] Make git-archimport log entries more consistent Miles Bader
2007-08-30  3:14 ` Junio C Hamano [this message]
2007-08-30  3:19   ` Miles Bader
2007-08-30  4:10     ` Junio C Hamano
2007-08-30  7:47       ` David Kastrup
2007-08-30 21:46         ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2007-08-16  5:01 Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmyw9af3q.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).