* [PATCH] git-submodule: re-enable 'status' as the default subcommand
@ 2007-08-04 14:25 Lars Hjemli
2007-08-17 7:25 ` Lars Hjemli
0 siblings, 1 reply; 4+ messages in thread
From: Lars Hjemli @ 2007-08-04 14:25 UTC (permalink / raw)
To: git
This was broken as part of ecda072380.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
---
git-submodule.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 2cfeadd..3320998 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -313,7 +313,7 @@ case "$add,$init,$update,$status,$cached" in
,,1,,)
modules_update "$@"
;;
-,,,1,*)
+,,,*,*)
modules_list "$@"
;;
*)
--
1.5.3.rc4-dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] git-submodule: re-enable 'status' as the default subcommand
2007-08-04 14:25 [PATCH] git-submodule: re-enable 'status' as the default subcommand Lars Hjemli
@ 2007-08-17 7:25 ` Lars Hjemli
2007-08-17 8:10 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Lars Hjemli @ 2007-08-17 7:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Hi
I got no response on this patch, was it simply overlooked? I really think
$ git submodule
should show the available submodules and their status.
--
larsh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-submodule: re-enable 'status' as the default subcommand
2007-08-17 7:25 ` Lars Hjemli
@ 2007-08-17 8:10 ` Junio C Hamano
2007-08-17 9:09 ` Sven Verdoolaege
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2007-08-17 8:10 UTC (permalink / raw)
To: Lars Hjemli; +Cc: git, skimo
"Lars Hjemli" <lh@elementstorage.no> writes:
> I got no response on this patch, was it simply overlooked? I really think
>
> $ git submodule
>
> should show the available submodules and their status.
Probably. I do not think of any other alternative behaviour
that would make sense.
Sven?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-submodule: re-enable 'status' as the default subcommand
2007-08-17 8:10 ` Junio C Hamano
@ 2007-08-17 9:09 ` Sven Verdoolaege
0 siblings, 0 replies; 4+ messages in thread
From: Sven Verdoolaege @ 2007-08-17 9:09 UTC (permalink / raw)
To: Lars Hjemli, Junio C Hamano; +Cc: git, Lars Hjemli
On Sat, Aug 04, 2007 at 04:25:53PM +0200, Lars Hjemli wrote:
> This was broken as part of ecda072380.
>
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
> git-submodule.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 2cfeadd..3320998 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -313,7 +313,7 @@ case "$add,$init,$update,$status,$cached" in
> ,,1,,)
> modules_update "$@"
> ;;
> -,,,1,*)
> +,,,*,*)
> modules_list "$@"
> ;;
> *)
Sorry about that. I didn't realize that it was supposed to do that
(it seems I didn't read the manual carefully enough) and I forgot
to mention I changed it.
On Fri, Aug 17, 2007 at 01:10:42AM -0700, Junio C Hamano wrote:
> "Lars Hjemli" <lh@elementstorage.no> writes:
> > I got no response on this patch, was it simply overlooked? I really think
> >
> > $ git submodule
> >
> > should show the available submodules and their status.
>
> Probably. I do not think of any other alternative behaviour
> that would make sense.
>
> Sven?
No objections from me.
skimo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-17 9:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-04 14:25 [PATCH] git-submodule: re-enable 'status' as the default subcommand Lars Hjemli
2007-08-17 7:25 ` Lars Hjemli
2007-08-17 8:10 ` Junio C Hamano
2007-08-17 9:09 ` Sven Verdoolaege
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).