Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>,
	git@vger.kernel.org
Subject: Re: [PATCH] Documentation: "bisect run" can be given bangs before the run script.
Date: Wed, 02 May 2007 22:29:42 -0700	[thread overview]
Message-ID: <7vmz0m3261.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070503070607.fa2ffe92.chriscool@tuxfamily.org> (Christian Couder's message of "Thu, 3 May 2007 07:06:07 +0200")

I am not convinced that '!' is a good extension for two and half
reasons.

 * The expected use is not quite clear.  If it is not used to
   run a custom test script but something stock as "make", by
   the nature of UNIX exit status convention, you are looking
   for the commit that _fixed_ some breakage (i.e. "which commit
   fixed the compilation error?").  While sometimes that is a
   useful thing to do, it feels somewhat of limited value.

   On the other hand, if you are running a custom test script, I
   do not think it is unreasonable to always require that a test
   script to signal "bad" with small non-zero, "good" with zero,
   and error with high non-zero status, as we already do.

 * How should this interact with the "high non-zero status means
   an error and we cannot bisect" return convention?

 * I was hoping that we can officially support "don't know,
   cannot test this one, please give me another" for interactive
   use, and at the same time allow the run-script used by
   "git bisect run" to signal such with a special exit value
   (perhaps "exit 42").  Taken together with the previous point,
   it is not clear how '!' should interact with such an
   enhancement.

  reply	other threads:[~2007-05-03  5:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03  5:06 [PATCH] Documentation: "bisect run" can be given bangs before the run script Christian Couder
2007-05-03  5:29 ` Junio C Hamano [this message]
2007-05-03  7:03   ` Uwe Kleine-König
2007-05-05 12:57   ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmz0m3261.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=ukleinek@informatik.uni-freiburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox