From: Junio C Hamano <junkio@cox.net>
To: Jason Riedy <ejr@EECS.Berkeley.EDU>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Include Makefile.localdef in Makefile, if it exists.
Date: Sat, 03 Dec 2005 11:14:43 -0800 [thread overview]
Message-ID: <7vmzjixaak.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 3061.1133591717@lotus.CS.Berkeley.EDU
Jason Riedy <ejr@EECS.Berkeley.EDU> writes:
> ... I might
> send along such a patch, along with a note about config.mak in
> INSTALL...
Please don't, unless you are confident your change can satisfy
_everybody_.
People with makefile needs that are more "advanced" (that is,
something a simple "-include config.mak" cannot easily satisfy)
can do any number of things without touching Makefile I ship.
Examples include:
- have own makefile, include Makefile.
- have onw Make script, run "make -f Makefile" with preset
"bindir=HERE NO_XXX=NoThanks" to reduce typing.
- have own makefile, whose build target depends on Make.file
and runs "make -f Make.file", with a build rule for Make.file
to munge Makefile using custom perl/sed into it.
prev parent reply other threads:[~2005-12-03 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 23:11 [PATCH] Include Makefile.localdef in Makefile, if it exists Jason Riedy
2005-12-03 2:23 ` Johannes Schindelin
2005-12-03 6:35 ` Jason Riedy
2005-12-03 10:45 ` Johannes Schindelin
2005-12-03 19:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmzjixaak.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=ejr@EECS.Berkeley.EDU \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).