From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Timo Hirvonen <tihirvon@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Move couple of ifdefs after "include config.mk"
Date: Thu, 01 Dec 2005 01:04:24 -0800 [thread overview]
Message-ID: <7vmzjlkx2f.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0512010906400.22709@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Thu, 1 Dec 2005 09:08:27 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> But it is only one line, heck only 20 bytes!
Hey, don't get so piped up. Timo's patch has already been
merged (thanks, Timo).
But think about it a bit.
If you need an override, you have to write down and maintain
those YesPlease _somewhere_ yourself anyway, outside what I
ship. Either "config.mak" or "Make" script.
If we have '-include' in the Makefile, we need to make a
decision if what we are adding to the Makefile should be
overridable by that config.mak every time, exactly because
whatever is included becomes part of the Makefile. IOW, that
"only 20 bytes" adds work for the Makefile maintainer.
"Make" script method is a command line override to the "make"
program, which takes precedence and does not have that problem.
next prev parent reply other threads:[~2005-12-01 9:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-30 23:23 [PATCH] Move "-include config.mak" to end of configuration section Timo Hirvonen
2005-12-01 0:46 ` Johannes Schindelin
2005-12-01 1:32 ` [PATCH] Move couple of ifdefs after "include config.mk" Timo Hirvonen
2005-12-01 1:43 ` Junio C Hamano
2005-12-01 8:08 ` Johannes Schindelin
2005-12-01 9:04 ` Junio C Hamano [this message]
2005-12-01 9:40 ` Alex Riesen
2005-12-01 9:45 ` Junio C Hamano
2005-12-01 9:53 ` Alex Riesen
2005-12-01 10:16 ` Junio C Hamano
2005-12-01 12:51 ` Alex Riesen
2005-12-03 2:31 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmzjlkx2f.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=tihirvon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).