From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] exclude: fix a bug in prefix comparison optimization
Date: Sun, 14 Oct 2012 11:25:48 -0700 [thread overview]
Message-ID: <7vobk4ykpf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7v8vb9yn09.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 14 Oct 2012 10:36:06 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Comparing the corresponding code in dir.c, there is no "compare the
> literal prefix part with strcmp() before doing the fnmatch()"
> optimization. Intended?
>
> (warning: I haven't had my caffeine yet)
And it turns out that at the point I wrote the response, I still had
the attr-match-optim-more updates to be read in my mailbox ;-)
next prev parent reply other threads:[~2012-10-14 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 11:35 [PATCH] exclude: fix a bug in prefix comparison optimization Nguyễn Thái Ngọc Duy
2012-10-14 17:36 ` Junio C Hamano
2012-10-14 18:25 ` Junio C Hamano [this message]
2012-10-15 4:09 ` Nguyen Thai Ngoc Duy
2012-10-15 4:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vobk4ykpf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).