From: Junio C Hamano <gitster@pobox.com>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>, git@vger.kernel.org
Subject: Re: [PATCH v4] Thunderbird: fix appp.sh format problems
Date: Sun, 02 Sep 2012 13:42:44 -0700 [thread overview]
Message-ID: <7voblognny.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 50425F8B.5020406@gmail.com
Marco Stornelli <marco.stornelli@gmail.com> writes:
> Il 01/09/2012 15:59, Johannes Sixt ha scritto:
>
>> Look how you write:
>>
>> perl -e '... $ENV{'PATCHTMP'} ...'
>>
>> That is, perl actually sees this script:
>>
>> ... $ENV{PATCHTMP} ...
>>
>> (no quotes around PATCHTMP). That my be perfectly valid perl, but is not
>> what you intended.
>
> I don't understand what you mean when you say "is not what you
> intended"...
When you wrote this:
CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'};...
which one of the following did you mean to feed Perl?
(1) open FILE, $ENV{'PATCHTMP'};
(2) open FILE, $ENV{PATCHTMP};
The patch text makes it look as if you wanted to do (1), but what is
fed to perl is (2), as Johannes points out.
Saying:
CCS=`perl -e 'local $/=undef; open FILE, $ENV{PATCHTMP};...
would have been more natural if you really meant to do (2), don't
you think? So what you wrote is at least misleading.
But I think I agree with Johannes's rewrite of the loop, so this may
be a moot point.
next prev parent reply other threads:[~2012-09-02 20:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 14:09 [PATCH v4] Thunderbird: fix appp.sh format problems Marco Stornelli
2012-08-31 17:08 ` Junio C Hamano
2012-09-01 7:52 ` Marco Stornelli
2012-09-02 18:44 ` Junio C Hamano
2012-08-31 20:01 ` Junio C Hamano
2012-08-31 21:35 ` Johannes Sixt
2012-09-01 7:43 ` Marco Stornelli
2012-09-01 13:59 ` Johannes Sixt
2012-09-01 19:18 ` Marco Stornelli
2012-09-02 20:42 ` Junio C Hamano [this message]
2012-09-03 10:51 ` Marco Stornelli
2012-09-03 15:48 ` Marco Stornelli
2012-09-03 20:16 ` Junio C Hamano
2012-09-04 6:37 ` Marco Stornelli
2012-09-04 9:01 ` Junio C Hamano
2012-09-04 11:22 ` Marco Stornelli
2012-09-04 15:49 ` Junio C Hamano
2012-09-04 18:59 ` Marco Stornelli
2012-09-04 19:22 ` Junio C Hamano
2012-09-05 6:30 ` Marco Stornelli
2012-09-02 18:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7voblognny.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=marco.stornelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).