From: Junio C Hamano <gitster@pobox.com>
To: "Neal Kreitzinger" <neal@rsss.com>
Cc: git@vger.kernel.org
Subject: Re: how do you review auto-resolved files
Date: Tue, 21 Feb 2012 15:52:25 -0800 [thread overview]
Message-ID: <7vobsreocm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <ji0vik$e48$1@dough.gmane.org> (Neal Kreitzinger's message of "Tue, 21 Feb 2012 14:41:57 -0600")
"Neal Kreitzinger" <neal@rsss.com> writes:
> If I expect/assume you are going to review the
> auto-resolutions after-the-fact then you can neglect this because you:
>
> - have become complacent that git usually does-what-you-want so "you don't
> really need to do it",
> - are lazy and do it half-way,
> - forget to do it,
> - think "git magically does your work for you",
> - don't know how to do it,
> - don't even realize that anything auto-resolved or what auto-resolved,
> - decide you don't have to do it because that is what testing if for,
> - you think that your time is so valuable that an ounce-of-prevention on
> your part is not worth a pound-of-cure on the part of others.
A couple more bullet points I can think of off the top of my head, after
making sure that you do not count what "rerere" does as part of the
"auto-resolution", to add to the above list are:
- know git is stupid and errs on the safe side, punting anything remotely
complex;
- know that textual non-conflicts that occur in the same file have the
same risk of having semantic conflict across different files, so
singling out "touched the same file but did not conflict" any special
is pointless, but in either case, the chance of having such a conflict
is small enough that completing the merge (and other merges) first and
then checking the overall result is more efficient use of your time,
because you have to eyeball the result at least once anyway before
pushing it out.
prev parent reply other threads:[~2012-02-21 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 20:41 how do you review auto-resolved files Neal Kreitzinger
2012-02-21 21:19 ` Junio C Hamano
2012-02-21 23:22 ` Neal Kreitzinger
2012-02-22 7:28 ` Jeff King
2012-02-22 15:24 ` Zbigniew Jędrzejewski-Szmek
2012-02-21 23:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vobsreocm.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=neal@rsss.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).