From: Junio C Hamano <gitster@pobox.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] StGit patch series import
Date: Sun, 24 May 2009 23:39:08 -0700 [thread overview]
Message-ID: <7vocthy9df.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: cb7bb73a0905241603r4949abb5g1a9e861aba40c6fe@mail.gmail.com
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
> But then the name munge would not be descriptive of what the command
> does. If git am is to be left untouched, I would rather then have
> something like git import-patches that accepts patches in 'any'
> format,...
There is no need to introduce any new program, I think.
Nobody is against your teaching the "git am" callchain to accept things
other than Berkeley mbox. "git am" is "import-patches" in that sense
already.
You can add a conditional (perhaps triggered by a "the patches are in this
format" command line option) to "git am" to alter the way it splits the
input into individual pieces of e-mail, named 0001, 0002, 0003, ..., and
leaves the total number of message in $dotest/last.
Currently we call "git-mailsplit" to do all of that; your new conditional
will take StGIT export, and instead of calling "git-mailsplit", read the
series file and process individual patch files into 0001, 0002,... that
are in proper mbox format (i.e. you would need to fix the "Subject: " less
title line when you do this), and leave the total number of patches in
$dotest/last file.
With that change, the main loop that iterates 'while test "$this" -le
"$last"' does not have to change, right?
We could for example add RMAIL format support in the same way.
next prev parent reply other threads:[~2009-05-25 6:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 7:19 [PATCH 0/2] StGit patch series import Giuseppe Bilotta
2009-05-24 20:49 ` Junio C Hamano
2009-05-24 21:43 ` Giuseppe Bilotta
2009-05-24 21:55 ` Sverre Rabbelier
2009-05-24 22:04 ` Giuseppe Bilotta
2009-05-24 22:05 ` Sverre Rabbelier
2009-05-24 22:02 ` Junio C Hamano
2009-05-24 22:18 ` Giuseppe Bilotta
2009-05-24 22:28 ` Sverre Rabbelier
2009-05-24 22:53 ` Giuseppe Bilotta
2009-05-24 22:57 ` Sverre Rabbelier
2009-05-24 23:03 ` Giuseppe Bilotta
2009-05-25 6:39 ` Junio C Hamano [this message]
2009-05-25 7:19 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vocthy9df.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).