From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, John Tapsell <johnflux@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 3/4] bisect: fix reading more than one path in "$GIT_DIR/BISECT_NAMES"
Date: Mon, 30 Mar 2009 00:59:16 -0700 [thread overview]
Message-ID: <7vocvjh25n.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090329114457.c6fca0fe.chriscool@tuxfamily.org
Christian Couder <chriscool@tuxfamily.org> writes:
> The implementation of "read_bisect_paths" worked with only one
> path in each line of "$GIT_DIR/BISECT_NAMES", but the paths are all
> stored on one line by "git-bisect.sh".
>
> So we have to process all the paths that may be on each line.
This is "oops, the previous one is broken", for a series that was not yet
'next' worthy, so I squashed the fix and rebuilt the topic, together with
your other patches.
The series now looks like this:
$ git log --oneline --boundary master..cc/bisect-filter
b54809a bisect--helper: string output variables together with "&&"
fd5a6a8 rev-list: pass "int flags" as last argument of "show_bisect_vars"
e2c52e1 t6030: test bisecting with paths
56fac26 bisect: use "bisect--helper" and remove "filter_skipped" function
650bafa bisect: implement "read_bisect_paths" to read paths in "$GIT_DIR/BISECT_NAMES"
a79b083 bisect--helper: implement "git bisect--helper"
29adb27 quote: add "sq_dequote_to_argv" to put unwrapped args in an argv array
ccc12f5 quote: implement "sq_dequote_many" to unwrap many args in one string
a292c81 rev-list: call new "filter_skip" function
58f0b66 rev-list: pass "revs" to "show_bisect_vars"
41440cf rev-list: make "show_bisect_vars" non static
a650efd rev-list: move code to show bisect vars into its own function
2bc0667 rev-list: move bisect related code into its own file
7cc17b8 rev-list: make "bisect_list" variable local to "cmd_rev_list"
52ffe77 refs: add "for_each_bisect_ref" function
-89fbda2 Merge branch 'maint'
I've tweaked a few patches before applying, but they all looked basically
sane. Unless I hear from other people in a few days , I'd say we merge it
to 'next' and start cooking it.
Thanks.
next prev parent reply other threads:[~2009-03-30 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 9:44 [PATCH 3/4] bisect: fix reading more than one path in "$GIT_DIR/BISECT_NAMES" Christian Couder
2009-03-30 7:59 ` Junio C Hamano [this message]
2009-03-31 5:36 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vocvjh25n.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=johnflux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).