git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Wincent Colaiuta <win@wincent.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Grammar fixes to "merge" and "patch-id" docs
Date: Wed, 25 Mar 2009 11:33:52 -0700	[thread overview]
Message-ID: <7vocvp310v.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1238005422-7647-1-git-send-email-win@wincent.com> (Wincent Colaiuta's message of "Wed, 25 Mar 2009 19:23:42 +0100")

Wincent Colaiuta <win@wincent.com> writes:

>  If you tried a merge which resulted in a complex conflicts and
> -would want to start over, you can recover with 'git-reset'.
> +want to start over, you can recover with 'git-reset'.

Reads Ok to me either way...

> diff --git a/Documentation/merge-strategies.txt b/Documentation/merge-strategies.txt
> index 1276f85..ee7f754 100644
> --- a/Documentation/merge-strategies.txt
> +++ b/Documentation/merge-strategies.txt
> @@ -3,15 +3,15 @@ MERGE STRATEGIES
>  
>  resolve::
>  	This can only resolve two heads (i.e. the current branch
> -	and another branch you pulled from) using 3-way merge
> +	and another branch you pulled from) using a 3-way merge
>  	algorithm.  It tries to carefully detect criss-cross

Hmph, would that be an 'a' or 'the'?

>  recursive::
> -	This can only resolve two heads using 3-way merge
> -	algorithm.  When there are more than one common
> -	ancestors that can be used for 3-way merge, it creates a
> +	This can only resolve two heads using a 3-way merge
> +	algorithm.  When there is more than one common
> +	ancestor that can be used for 3-way merge, it creates a

Do you need an article before the latter "3-way merge", perhaps "the"?

> @@ -22,11 +22,11 @@ recursive::
>  	pulling or merging one branch.
>  
>  octopus::
> -	This resolves more than two-head case, but refuses to do
> -	complex merge that needs manual resolution.  It is
> +	This resolves the more than two-heads case, but refuses to do
> +	a complex merge that needs manual resolution.  It is

Perhaps "resolves cases with more than two heads" is easier to read?

  reply	other threads:[~2009-03-25 18:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 18:23 [PATCH] Grammar fixes to "merge" and "patch-id" docs Wincent Colaiuta
2009-03-25 18:33 ` Junio C Hamano [this message]
2009-03-25 19:03   ` Wincent Colaiuta
2009-03-26  2:20   ` Jeff King
2009-03-26  9:39     ` [PATCH] Grammar fix for "git merge" man page Wincent Colaiuta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vocvp310v.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).