git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Santi Béjar" <santi@agolina.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] commit: more compact summary and without extra quotes
Date: Mon, 19 Jan 2009 19:49:19 -0800	[thread overview]
Message-ID: <7vocy2ocw0.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <adf1fd3d0901191600k6fd7a364h3e55f9600960df03@mail.gmail.com> (Santi Béjar's message of "Tue, 20 Jan 2009 01:00:30 +0100")

Santi Béjar <santi@agolina.net> writes:

>>> As discussed in the git mailing list:
>>>
>>> http://marc.info/?l=git&m=122765031208922&w=2
>>>
>>> Signed-off-by: Santi Béjar <santi@agolina.net>
>>> ---
>>
>> You really want to move the link after the ---.  I often read commit
>> messages off-line, and let me tell you: I am not really happy reading
>> links then.  Not at all.
>
> OK, less work for me :-)

I do not mind URL in the commit log; it would help me or other forgetful
people three months from now if we need to go back to the original
discussion.

I however agree with Dscho that it is irritating when somebody uses URL to
avoid summarizing the issue himself.  If somebody cares enough and
understands the issues discussed at URL to come up with a patch that is
worth applying, he surely should be able to summarize the primary idea and
issues involved in a few paragraphs.

A summary of discussion in addition to URL would save everybody's time.

  reply	other threads:[~2009-01-20  3:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-19 22:45 [PATCH] commit: more compact summary and without extra quotes Santi Béjar
2009-01-19 23:46 ` Johannes Schindelin
2009-01-20  0:00   ` Santi Béjar
2009-01-20  3:49     ` Junio C Hamano [this message]
2009-01-20 10:10       ` Johannes Schindelin
2009-01-20 10:29         ` Santi Béjar
2009-01-20  4:14 ` Jeff King
2009-01-20  7:04 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vocy2ocw0.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=santi@agolina.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).