From: Junio C Hamano <gitster@pobox.com>
To: Chris Frey <cdfrey@foursquare.net>
Cc: git@vger.kernel.org
Subject: Re: git-status for submodules
Date: Fri, 21 Nov 2008 16:55:41 -0800 [thread overview]
Message-ID: <7vod08poj6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081121224247.GB27049@foursquare.net> (Chris Frey's message of "Fri, 21 Nov 2008 17:42:47 -0500")
Chris Frey <cdfrey@foursquare.net> writes:
> It's true that subproject X has to be able to stand on its own. That
> is important from git's perspective as well as for managing subprojects
> in general.
>
> But I don't see the advantage in hiding submodule information from the
> supermodule, and if that hiding is by design, I think the design is wrong.
There is no "wrong" design in git. There are ones that do not cover 360
degrees of the field, because nobody designed out let alone coded to cover
such use cases.
> In order to manage the various modules effectively (actually, in order to
> manage any git repo effectively), you need to know what's changed,
> and git-status is the way to do that. I don't see why submodules should
> break that.
Changes to parts of submodules are fundamentally different from changes to
parts of your main project. A change to what commit the superproject
wants for a submodule is at the same level as a change to what content the
superprojects wants for a blob.
It is not unreasonable to want to have both modes of operation, one that
shows the uncommitted details in the submodule even when you are viewing
from the superproject (which does not exist), and one that does not (which
does exist, because somebody felt need for it and coded so).
In order to see the status of your working tree, you may want to take into
account what untracked files are in there, but some people do not want to,
so there is an option to pick which behaviour you want. We would need a
similar switch.
> With the new submodule foreach command, though, it should be possible
> to add that as a config option, similar to the way submodule summary
> is handled now. Maybe I can cook up a patch for that.
Yup, that's the spirit.
prev parent reply other threads:[~2008-11-22 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 3:36 git-status for submodules Chris Frey
2008-11-21 14:56 ` Junio C Hamano
2008-11-21 15:27 ` Johan Herland
2008-11-21 21:56 ` Chris Frey
2008-11-21 22:42 ` Chris Frey
2008-11-22 0:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vod08poj6.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=cdfrey@foursquare.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).