git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org, Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH] Set proxy override with http_init()
Date: Wed, 27 Feb 2008 11:18:16 -0800	[thread overview]
Message-ID: <7voda2us1z.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1204097780-29581-1-git-send-email-mh@glandium.org> (Mike Hommey's message of "Wed, 27 Feb 2008 08:36:20 +0100")

Mike Hommey <mh@glandium.org> writes:

> In transport.c, proxy setting (the one from the remote conf) was set through
> curl_easy_setopt() call, while http.c already does the same with the
> http.proxy setting. We now just use this infrastructure instead, and make
> http_init() now take the proxy url as argument.
>
> At the same time, we make get_http_walker() take a proxy argument too, and
> pass it to http_init(), which makes remote defined proxy be used for more
> than get_refs_via_curl().
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---

Thanks.  I am kicking this to Daniel for a review ;-).

  reply	other threads:[~2008-02-27 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 23:46 FW: git via http protocol _and_ a proxy using NTLM authentication -- git 1.5.4.2 & curl 7.18.0 Ken.Fuchs
2008-02-27  7:20 ` Mike Hommey
2008-02-27  7:29   ` Mike Hommey
2008-02-27  7:36   ` [PATCH] Set proxy override with http_init() Mike Hommey
2008-02-27 19:18     ` Junio C Hamano [this message]
2008-02-27 19:59     ` Daniel Barkalow
2008-02-27 20:05       ` Mike Hommey
2008-02-27 20:35         ` Mike Hommey
2008-02-27 20:39           ` Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7voda2us1z.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=mh@glandium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).