From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: git-push: forced update of tag shows unabbreviated SHA1
Date: Thu, 31 Jan 2008 02:21:49 -0800 [thread overview]
Message-ID: <7vodb2cn2a.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080131100625.GB25546@coredump.intra.peff.net> (Jeff King's message of "Thu, 31 Jan 2008 05:06:25 -0500")
Jeff King <peff@peff.net> writes:
> ... then for every 12345678* that we don't have, we will claim
> the correct abbreviation is 1234568.
>
> In practice, I doubt this is a problem.
>
> But getting back to your point: yes, I agree it is a little ugly.
> Rewriting find_unique_abbrev would be necessary for fixing it, and I'm
> not sure it is worth the trouble.
I think that needs to be done carefully. I recall some callers
do expect it to return NULL for nonexistant objects, so the bug
you noted above as "rare case" may need to be fixed, which I
think is more important than coming up with a potentially too
short abbreviation.
next prev parent reply other threads:[~2008-01-31 10:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 9:27 git-push: forced update of tag shows unabbreviated SHA1 Johannes Sixt
2008-01-31 9:37 ` Junio C Hamano
2008-01-31 10:01 ` Johannes Sixt
2008-01-31 10:06 ` Jeff King
2008-01-31 10:21 ` Junio C Hamano [this message]
2008-01-31 10:39 ` Jeff King
2008-01-31 10:27 ` Jeff King
2008-01-31 10:38 ` Junio C Hamano
2008-01-31 10:41 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vodb2cn2a.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).