From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Bernt Hansen <bernt@alumni.uwaterloo.ca>,
git@vger.kernel.org
Subject: Re: [PATCH] Force new line at end of commit message
Date: Sat, 29 Dec 2007 16:19:37 -0800 [thread overview]
Message-ID: <7vodc99gpy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712291426500.14355@wbgn129.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Sat, 29 Dec 2007 14:31:14 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> echo "# This is a combination of $COUNT commits."
>> - sed -n "2,\$p" < "$SQUASH_MSG"
>> + sed -e 1d -e '2,/^./{
>> + /^$/d
>> + }' <"$SQUASH_MSG"
>
> If I read this correctly (haven't tested), then _all_ empty lines are
> removed from the SQUASH_MSG, right? This is not what I want.
That is no what I wanted either.
"1d" removes the "# This is a combination of <$n> commits." from
the previous round, "2,/^./{ ... }" says apply what's in {} to
lines from second line to the first non-empty line, and what's
in {} is to remove empty ones.
> Unfortunately, I am unable to provide a proper patch with proper testing
> right now,...
That's Ok. Seeing what the patch already in front of you does
would be less time consuming.
next prev parent reply other threads:[~2007-12-30 0:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 0:35 git rebase -i / git-gui bug Bernt Hansen
2007-12-20 4:47 ` Bernt Hansen
2007-12-20 7:12 ` [PATCH] Reallow git-rebase --interactive --continue if commit is unnecessary Shawn O. Pearce
2007-12-20 7:15 ` Junio C Hamano
2007-12-20 7:31 ` Shawn O. Pearce
2007-12-20 9:35 ` Junio C Hamano
2007-12-26 23:48 ` Junio C Hamano
2007-12-29 13:26 ` Johannes Schindelin
2007-12-20 7:52 ` Matthieu Moy
2007-12-24 14:31 ` [PATCH] Force new line at end of commit message Bernt Hansen
2007-12-24 17:38 ` Johannes Schindelin
2007-12-25 4:42 ` Shawn O. Pearce
2007-12-25 9:34 ` Junio C Hamano
2007-12-26 17:47 ` Bernt Hansen
2007-12-27 4:19 ` Shawn O. Pearce
2007-12-28 2:15 ` [PATCH] git-gui: Make commit log messages end with a newline Bernt Hansen
2007-12-26 19:36 ` [PATCH] Force new line at end of commit message Junio C Hamano
2007-12-29 13:31 ` Johannes Schindelin
2007-12-30 0:19 ` Junio C Hamano [this message]
2007-12-30 10:26 ` Johannes Schindelin
2007-12-30 10:51 ` Junio C Hamano
2007-12-30 11:03 ` Johannes Schindelin
2007-12-30 11:45 ` Junio C Hamano
2007-12-30 11:57 ` しらいしななこ
2007-12-30 12:21 ` Junio C Hamano
2007-12-30 12:05 ` Junio C Hamano
2007-12-30 15:50 ` Johannes Schindelin
2007-12-25 4:46 ` Shawn O. Pearce
[not found] <200712301158.lBUBwT3u004608@mi1.bluebottle.com>
2007-12-30 15:51 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vodc99gpy.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bernt@alumni.uwaterloo.ca \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).