From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Christian Couder <chriscool@tuxfamily.org>,
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Subject: [PATCH 1/3] git-bisect: war on "sed"
Date: Thu, 15 Nov 2007 01:00:56 -0800 [thread overview]
Message-ID: <7voddv6fxz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071115081807.06fe092b.chriscool@tuxfamily.org> (Christian Couder's message of "Thu, 15 Nov 2007 08:18:07 +0100")
We do not need to pipe "echo" to "sed" only to strip refs/heads/
from the beginning. We are assuming not-so-ancient shells these
days.
Also there is no need to avoid assuming \012 is the LF; we do
not run on EBCDIC, sorry. Other parts of the script already
uses tr to convert separator to LF that way.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
git-bisect.sh | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 46a7b8d..3a21033 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -71,7 +71,7 @@ bisect_start() {
;;
refs/heads/*)
[ -s "$GIT_DIR/head-name" ] && die "won't bisect on seeked tree"
- echo "$head" | sed 's#^refs/heads/##' >"$GIT_DIR/head-name"
+ echo "${head#refs/heads/}" >"$GIT_DIR/head-name"
;;
*)
die "Bad HEAD - strange symbolic ref"
@@ -275,8 +275,7 @@ exit_if_skipped_commits () {
if expr "$_tried" : ".*[|].*" > /dev/null ; then
echo "There are only 'skip'ped commit left to test."
echo "The first bad commit could be any of:"
- echo "$_tried" | sed -e 's/[|]/\
-/g'
+ echo "$_tried" | tr '[|]' '[\012]'
echo "We cannot bisect more!"
exit 2
fi
--
1.5.3.5.1780.gca2b
next prev parent reply other threads:[~2007-11-15 9:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 7:18 [PATCH v2] Bisect reset: remove bisect refs that may have been packed Christian Couder
2007-11-15 8:18 ` Junio C Hamano
2007-11-15 8:27 ` Johannes Sixt
2007-11-15 8:49 ` Shawn O. Pearce
2007-11-15 8:52 ` Jeff King
2007-11-15 12:10 ` Johannes Schindelin
2007-11-15 8:34 ` Junio C Hamano
2007-11-15 9:00 ` Junio C Hamano [this message]
2007-11-15 9:29 ` [PATCH 1/3] git-bisect: war on "sed" Miles Bader
2007-11-15 9:36 ` Wincent Colaiuta
2007-11-15 9:53 ` Miles Bader
2007-11-15 10:06 ` Andreas Ericsson
2007-11-15 10:14 ` David Kastrup
[not found] ` <86tznn4y7v.fsf@lola.quinscape.zz>
2007-11-15 11:00 ` Miles Bader
2007-11-15 11:18 ` David Kastrup
2007-11-15 12:59 ` Miles Bader
2007-11-15 9:01 ` [PATCH 2/3] git-bisect: use update-ref to mark good/bad commits Junio C Hamano
2007-11-15 9:01 ` [PATCH 3/3] git-bisect: modernize branch shuffling hack Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7voddv6fxz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).