* [PATCH] t6131 - skip tests if on case-insensitive file system
@ 2013-07-17 13:22 Mark Levedahl
2013-07-17 13:42 ` Duy Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Mark Levedahl @ 2013-07-17 13:22 UTC (permalink / raw)
To: git; +Cc: Mark Levedahl
This test fails on Cygwin where the default system configuration does not
support case sensitivity (only case retention), so don't run the test on
such systems.
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
t/t6131-pathspec-icase.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh
index 3215eef..8d4a7fc 100755
--- a/t/t6131-pathspec-icase.sh
+++ b/t/t6131-pathspec-icase.sh
@@ -3,6 +3,12 @@
test_description='test case insensitive pathspec limiting'
. ./test-lib.sh
+if test_have_prereq CASE_INSENSITIVE_FS
+then
+ skip_all='skipping case sensitive tests - case insensitive file system'
+ test_done
+fi
+
test_expect_success 'create commits with glob characters' '
test_commit bar bar &&
test_commit bAr bAr &&
--
1.8.3.2.0.63
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t6131 - skip tests if on case-insensitive file system
2013-07-17 13:22 [PATCH] t6131 - skip tests if on case-insensitive file system Mark Levedahl
@ 2013-07-17 13:42 ` Duy Nguyen
2013-07-17 19:47 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Duy Nguyen @ 2013-07-17 13:42 UTC (permalink / raw)
To: Mark Levedahl; +Cc: Git Mailing List
On Wed, Jul 17, 2013 at 8:22 PM, Mark Levedahl <mlevedahl@gmail.com> wrote:
> This test fails on Cygwin where the default system configuration does not
> support case sensitivity (only case retention), so don't run the test on
> such systems.
Yeah. I knew this when I wrote this test but forgot to put the check
in. Thanks. We can re-enable the test later, as it does not really
need case-insensitive filesystems.
>
> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
> ---
> t/t6131-pathspec-icase.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh
> index 3215eef..8d4a7fc 100755
> --- a/t/t6131-pathspec-icase.sh
> +++ b/t/t6131-pathspec-icase.sh
> @@ -3,6 +3,12 @@
> test_description='test case insensitive pathspec limiting'
> . ./test-lib.sh
>
> +if test_have_prereq CASE_INSENSITIVE_FS
> +then
> + skip_all='skipping case sensitive tests - case insensitive file system'
> + test_done
> +fi
> +
> test_expect_success 'create commits with glob characters' '
> test_commit bar bar &&
> test_commit bAr bAr &&
> --
> 1.8.3.2.0.63
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Duy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t6131 - skip tests if on case-insensitive file system
2013-07-17 13:42 ` Duy Nguyen
@ 2013-07-17 19:47 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2013-07-17 19:47 UTC (permalink / raw)
To: Duy Nguyen; +Cc: Mark Levedahl, Git Mailing List
Duy Nguyen <pclouds@gmail.com> writes:
> On Wed, Jul 17, 2013 at 8:22 PM, Mark Levedahl <mlevedahl@gmail.com> wrote:
>> This test fails on Cygwin where the default system configuration does not
>> support case sensitivity (only case retention), so don't run the test on
>> such systems.
>
> Yeah. I knew this when I wrote this test but forgot to put the check
> in. Thanks. We can re-enable the test later, as it does not really
> need case-insensitive filesystems.
Yeah, I tend to agree. You do not need to create case-colliding paths
for the purpose of :(icase) tests.
>
>>
>> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
>> ---
>> t/t6131-pathspec-icase.sh | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh
>> index 3215eef..8d4a7fc 100755
>> --- a/t/t6131-pathspec-icase.sh
>> +++ b/t/t6131-pathspec-icase.sh
>> @@ -3,6 +3,12 @@
>> test_description='test case insensitive pathspec limiting'
>> . ./test-lib.sh
>>
>> +if test_have_prereq CASE_INSENSITIVE_FS
>> +then
>> + skip_all='skipping case sensitive tests - case insensitive file system'
>> + test_done
>> +fi
>> +
>> test_expect_success 'create commits with glob characters' '
>> test_commit bar bar &&
>> test_commit bAr bAr &&
>> --
>> 1.8.3.2.0.63
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> Duy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-17 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 13:22 [PATCH] t6131 - skip tests if on case-insensitive file system Mark Levedahl
2013-07-17 13:42 ` Duy Nguyen
2013-07-17 19:47 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).