From: Junio C Hamano <gitster@pobox.com>
To: John Feuerstein <john@feurix.com>
Cc: git@vger.kernel.org
Subject: Re: Rebase fails because of apply.whitespace setting
Date: Mon, 19 Oct 2009 16:53:52 -0700 [thread overview]
Message-ID: <7vpr8juei7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4ADCF6E9.8090704@feurix.com> (John Feuerstein's message of "Tue\, 20 Oct 2009 01\:31\:53 +0200")
John Feuerstein <john@feurix.com> writes:
> I had to rewrite history recently (ugh -- private repo, not shared with
> anybody) and wanted to change the commit message of the root commit.
> During this I've encountered a failing git-rebase if apply.whitespace is
> set to "error".
>
> Should whitespace-errors really be detected when rebasing?
> (or worse: be "fixed" without explicitely asking for it when using a
> global apply.whitespace=fix setting)
I've seen this argued both ways. Some people seem to be happy that they
can use rebase with whitespace=fix to clean up their mess. Some people
quite rightly oppose it (I am slightly closer to the latter camp myself,
but that does not count that much).
I'd agree that whitespace=error won't help anybody here.
Perhaps rebase can be taught to take --whitespace=warn from the command
line to override whatever is in the configuration?
prev parent reply other threads:[~2009-10-19 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 23:31 Rebase fails because of apply.whitespace setting John Feuerstein
2009-10-19 23:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpr8juei7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=john@feurix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox