From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] make the new block-sha1 the default
Date: Mon, 24 Aug 2009 23:50:22 -0700 [thread overview]
Message-ID: <7vprakpett.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090825041859.GA10033@coredump.intra.peff.net> (Jeff King's message of "Tue\, 25 Aug 2009 00\:18\:59 -0400")
Jeff King <peff@peff.net> writes:
> On Mon, Aug 24, 2009 at 11:04:37PM -0400, Nicolas Pitre wrote:
>
>> ... and remove support for linking against the openssl SHA1 code.
>>
>> The block-sha1 implementation is not significantly worse and sometimes
>> even faster than the openssl SHA1 implementation. This allows for
>
> Is there a reason not to leave the option of linking against openssl?
I think it is a valid question. Why remove the _option_?
I would certainly understand it if you made BLK_SHA1 the _default_, though.
next prev parent reply other threads:[~2009-08-25 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 3:04 [PATCH/RFC] make the new block-sha1 the default Nicolas Pitre
2009-08-25 4:18 ` Jeff King
2009-08-25 6:50 ` Junio C Hamano [this message]
2009-08-25 17:33 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprakpett.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).