git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mark A Rada <marada@uwaterloo.ca>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-instaweb: fix mod_perl detection for apache2
Date: Sun, 09 Aug 2009 18:38:40 -0700	[thread overview]
Message-ID: <7vprb45ty7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4C22ECF8-8FBE-4E45-A7CF-EA1203B49AA7@mailservices.uwaterloo.ca> (Mark A. Rada's message of "Sat\, 8 Aug 2009 18\:24\:02 -0400")

Mark A Rada <marada@uwaterloo.ca> writes:

> The script was looking for something that matched the '^our $gitbin'
> regex, which no longer exists in gitweb.cgi.
>
> Now it looks for 'MOD_PERL', which should be on the line that checks
> to see if the script is running in a mod_perl environment.

Thanks.  That sounds like an ancient bug that in turn perhaps suggests
nobody uses instaweb.  Will apply to 'maint'..

  reply	other threads:[~2009-08-10  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-08 22:24 [PATCH] git-instaweb: fix mod_perl detection for apache2 Mark A Rada
2009-08-10  1:38 ` Junio C Hamano [this message]
2009-08-10  8:55   ` Jakub Narebski
2009-08-15 16:09     ` Mark A Rada
2009-08-18  7:45       ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprb45ty7.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=marada@uwaterloo.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).